New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Environment variable for muting eventlog setup errors. #16

Merged
merged 1 commit into from Jan 11, 2019

Conversation

Projects
None yet
2 participants
@jone
Copy link
Member

jone commented Jan 11, 2019

When running tests of other projects there is usually no eventlog configured. ftw.structlog then spams the test output.

For muting the setup errors in this situation an environment variable is introduced. The variable is only meant to be used in testing since we want to see the errors in production.

Environment variable for muting eventlog setup errors.
When running tests of other projects there is usually no eventlog
configured. ftw.structlog then spams the test output.

For muting the setup errors in this situation an environment variable
is introduced. The variable is only meant to be used in testing since
we want to see the errors in production.

@jone jone requested a review from lukasgraf Jan 11, 2019

@lukasgraf
Copy link
Member

lukasgraf left a comment

LGTM, thanks! 👍

@lukasgraf lukasgraf merged commit 572a12a into master Jan 11, 2019

1 check passed

CI Governor: test-plone-4.3.x.cfg Task #352718 succeeded
Details

@lukasgraf lukasgraf deleted the jone-mute-eventlog-setup-errors branch Jan 11, 2019

@jone

This comment has been minimized.

Copy link
Member

jone commented Jan 11, 2019

Thanks, sorry for missing the changelog 🙈

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment