Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python 3 Support #95

Open
wants to merge 27 commits into
base: master
from

Conversation

@buchi
Copy link
Member

buchi commented Nov 1, 2019

No description provided.

@buchi buchi force-pushed the plone52-python3 branch 3 times, most recently from a673dfc to 66a4db5 Nov 2, 2019
@buchi buchi force-pushed the plone52-python3 branch from 66a4db5 to 8b27b19 Nov 6, 2019
@buchi buchi marked this pull request as ready for review Nov 6, 2019
@buchi buchi requested a review from jone Nov 6, 2019
docs/HISTORY.txt Show resolved Hide resolved
Copy link
Member

jone left a comment

Very nice 👍 🎉 🍻

I think we need to plan the release of ftw.testing / ftw.builder and ftw.testbrowser a bit, so that we do not release them on the same day so that we can react on problems in the nightlies.

@@ -10,3 +10,4 @@ test-extras = tests,tests_plone4
# Downgrade collective.z3cform.datagridfield, since the Version 1.3.0 seems no
# longer compatible with Plone 4.x
collective.z3cform.datagridfield = 1.2
six = 1.12.0

This comment has been minimized.

Copy link
@jone

jone Nov 8, 2019

Member

Since six is not only used when testing ftw.testbrowser: should there be a version constraint for six in the setup.py of setup.py? Or why do we need to pin a certain version?

This comment has been minimized.

Copy link
@buchi

buchi Nov 8, 2019

Author Member

I've added the missing dependency for six with a version constraint.
Overriding the version pinning is still necessary since Plone pins that to an older version.

This comment has been minimized.

Copy link
@jone

jone Nov 11, 2019

Member

@buchi that means all 4.3 tests which upgrade to the new testbrowser will have to pin six up, right?
I think we should put the pinning in https://github.com/4teamwork/ftw-buildouts/blob/master/test-versions-plone-4.cfg then.

ftw.builder

[branches]
ftw.builder = python3

This comment has been minimized.

Copy link
@jone

jone Nov 8, 2019

Member

🚧 4teamwork/ftw.builder#59 needs to be merged / released first.

@@ -6,3 +6,8 @@ extensions +=
mr.developer

auto-checkout =
ftw.testing

This comment has been minimized.

Copy link
@jone

jone Nov 8, 2019

Member

🚧 Release of ftw.testing needed; should we add a version constraint to the setup.py then?

This comment has been minimized.

Copy link
@buchi

buchi Nov 8, 2019

Author Member

I've added a version constraint

This comment has been minimized.

Copy link
@jone

jone Nov 11, 2019

Member

ftw.testing = 2.0.0 was released

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.