Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the global ticketbox tabs. #86

Merged
merged 1 commit into from Mar 7, 2019

Conversation

Projects
None yet
2 participants
@mbaechtold
Copy link
Member

mbaechtold commented Mar 5, 2019

The name of the tab is used to build the name of the view to be loaded in the tab. But views named like tabbedview_view-Meine Aufträge do not exist. We can fix this by no longer using gettext objects in the tab configuration. If we do so, the names of the tabs are still internationalized automagically.

Before

image

After

image

@mbaechtold mbaechtold self-assigned this Mar 5, 2019

@mbaechtold mbaechtold force-pushed the mba/fix-global-tabs branch from acbb2f0 to 990763a Mar 5, 2019

@mbaechtold mbaechtold force-pushed the mba/fix-global-tabs branch from 034cdb9 to a9c1a05 Mar 6, 2019

@mbaechtold mbaechtold requested a review from jone Mar 6, 2019

@jone

jone approved these changes Mar 7, 2019

@mbaechtold mbaechtold merged commit 1bc3182 into master Mar 7, 2019

1 check passed

CI Governor: test-plone-4.3.x.cfg Task #372111 succeeded
Details

@mbaechtold mbaechtold deleted the mba/fix-global-tabs branch Mar 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.