New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reenable testserver selftest on jenkins by fixing port choosing. #5355

Merged
merged 2 commits into from Feb 12, 2019

Conversation

Projects
None yet
2 participants
@jone
Copy link
Member

jone commented Feb 8, 2019

Closes #5331

The port choosing method is switched to using a 0-port so that the OS chooses the port in the testserver.

This is done in order to avoid problems where the jenkins master chooses a port, but the test is run at the slave, on which the port is already used.

The robot server is extended so that it prints out the URLs including the chosen ports for the ZServer and the XMLRPC-server. The selftest script now needs to watch the stdout of the testserver process and wait until the URLs appear

Show resolved Hide resolved sources.cfg Outdated

@jone jone force-pushed the jone-fix-testserver-selftest branch from 792213b to 415eb2a Feb 11, 2019

Reenable testserver selftest on jenkins by fixing port choosing.
The port choosing method is switched to using a 0-port so that the OS
chooses the port in the testserver.

This is done in order to avoid problems where the jenkins master
chooses a port, but the test is run at the slave, on which the port is
already used.

The robot server is extended so that it prints out the URLs including
the chosen ports for the ZServer and the XMLRPC-server.
The selftest script now needs to watch the stdout of the testserver
process and wait until the URLs appear.

@jone jone force-pushed the jone-fix-testserver-selftest branch from 415eb2a to 9d6ccaf Feb 11, 2019

@jone jone changed the title 🚧Reenable testserver selftest on jenkins by fixing port choosing. Reenable testserver selftest on jenkins by fixing port choosing. Feb 11, 2019

@jone jone requested a review from 4teamwork/gever Feb 11, 2019

@jone

This comment has been minimized.

Copy link
Member Author

jone commented Feb 11, 2019

Ready for review.

The build https://ci.4teamwork.ch/builds/221662/tasks/364408 proves that this works on our jenkins slave.

@deiferni
Copy link
Member

deiferni left a comment

LGTM 👍

@deiferni deiferni merged commit bb0908c into master Feb 12, 2019

8 checks passed

CI Governor: test-docs-intern.cfg Task #364402 succeeded
Details
CI Governor: test-docs-public-fr.cfg Task #364403 succeeded
Details
CI Governor: test-docs-public.cfg Task #364404 succeeded
Details
CI Governor: test-i18n-de.cfg Task #364405 succeeded
Details
CI Governor: test-plone-4.3.x.cfg Task #364406 succeeded
Details
CI Governor: test-qa.cfg Task #364407 succeeded
Details
CI Governor: test-testserver-selftest.cfg Task #364408 succeeded
Details
CI Governor: test-xml-convention.cfg Task #364409 succeeded
Details

@deiferni deiferni deleted the jone-fix-testserver-selftest branch Feb 12, 2019

@deiferni deiferni added this to the Release 2019.1 milestone Feb 13, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment