New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Register and use a tree portlet builder for testing. #5360

Merged
merged 1 commit into from Feb 11, 2019

Conversation

Projects
None yet
2 participants
@jone
Copy link
Member

jone commented Feb 8, 2019

  • Register a new portlet builder tree portlet for building tree portlets.
  • Add a with_tree_portlet() option to the repository_root builder.
  • Setup the tree in the standard fixture with a portlet.

This is very useful when starting the testserver: until now there was no navigation, which was confusing, especially for non-geverists.

@jone jone requested a review from 4teamwork/gever Feb 8, 2019

@jone jone force-pushed the jone-tree-portlet-builder branch 3 times, most recently from 90306fa to 739899d Feb 8, 2019

@jone jone force-pushed the jone-tree-portlet-builder branch from 739899d to 1574915 Feb 8, 2019

@deiferni
Copy link
Member

deiferni left a comment

LGTM 👍

@deiferni deiferni merged commit df3f3e7 into master Feb 11, 2019

7 checks passed

CI Governor: test-docs-intern.cfg Task #363569 succeeded
Details
CI Governor: test-docs-public-fr.cfg Task #363570 succeeded
Details
CI Governor: test-docs-public.cfg Task #363571 succeeded
Details
CI Governor: test-i18n-de.cfg Task #363572 succeeded
Details
CI Governor: test-plone-4.3.x.cfg Task #363573 succeeded
Details
CI Governor: test-qa.cfg Task #363574 succeeded
Details
CI Governor: test-xml-convention.cfg Task #363575 succeeded
Details

@deiferni deiferni deleted the jone-tree-portlet-builder branch Feb 11, 2019

@deiferni deiferni added this to the Release 2019.1 milestone Feb 13, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment