Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merging the cropping feature from 1.0.5-ftw1 into 1.0.9. #1

Open
wants to merge 2 commits into
base: 1.0.9-ftw1
Choose a base branch
from

Conversation

mbaechtold
Copy link

🚧 ❗

@petschki
Copy link

hi, ever thought about participating in https://github.com/collective/plone.app.imagecropping ... maybe we can merge forces here :)

plone roadmap was pretty clear about merging cropping functionality into core https://dev.plone.org/ticket/10174

@maethu
Copy link

maethu commented Nov 11, 2014

Hey @petschki

We only need the automatic cropping feature, which was introduced by @ggozad

Add "scaling strategies", i.e. a parameter to image scales that defines 
whether the image should scale to fit as is in the scale or whether it 
should be first cropped and then fill the scale dimensions.

This allows us to append fill to any scale defined in the plone imaging control panel.
The images will be automatically cropped.

Example:
Plone mini scale: 200:200 fill
Uploaded Image: 1000 x 500 Pixel

The output should be a 200 x 200 cropped image, not a 200 x 100 scaled image.

We are not interested in the manual cropping feature in this branch , because of https://github.com/collective/plone.app.imagecropping.
We are already using this package πŸ˜„

Or is there any chance to get the automatic cropping feature in plone.app.imagecropping?

@petschki
Copy link

@maethu see discussion here collective/plone.app.imagecropping#13 ... everyone would highly appreciate an autocrop-feature ... maybe you have additinal ideas to get this done in p.a.imagecropping

@maethu
Copy link

maethu commented Nov 11, 2014

@petschki A cool, I was no aware of that.
I'll have a look, thank you very much!

Version comparison has changed in setuptools 8.x.
@maethu maethu removed their assignment Jun 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants