Skip to content

[4.5] Correct get_human_readable() to return proper example data #163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 3, 2025
Merged

[4.5] Correct get_human_readable() to return proper example data #163

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions fiftyone_devicedetection_examples/src/fiftyone_devicedetection_examples/example_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,13 +73,13 @@ def set_data_file_in_config(config, file):
@staticmethod
def get_human_readable(device, property):
try:
value = getattr(device, property)
if value.has_value():
return value.value()
else:
return f"Unknown ({value.no_value_message()})"
except:
value = device.get(property)
except Exception:
return "Property not found in data file"
if value and value.has_value():
return value.value()
else:
return f"Unknown ({value.no_value_message()})"

@staticmethod
def get_resource_key():
Expand Down