Skip to content

SetHeaderElement.php: revert try-catch fix #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 11, 2023
Merged

SetHeaderElement.php: revert try-catch fix #15

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions SetHeaderElement.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,9 +152,13 @@ public function getPropertyValue($flowData, $elementKey, $propertyKey){
}

$propertyKey = strtolower($propertyKey);
if (isset($elementData->$propertyKey)) {
// TODO: catch is never called here. Consider replacing it with:
// if (isset($elementData->$propertyKey))
// The change can't be made right now, as it causes device-detection-php
// tests to fail. Further investigation is needed.
try {
$property = $elementData->$propertyKey;
} else {
} catch (Exception $e) {
echo sprintf(Messages::PROPERTY_NOT_FOUND, $propertyKey, $elementKey);
return "";
}
Expand Down