Replace Mustache template with the one provided by the submodule #24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e Mustache template with the one provided by the submodule' Replace Mustache template with the one provided by the submodule
justadreamer
requested changes
Nov 10, 2023
Contributor
There was a problem hiding this comment.
Please make sure the device-detection-php/examples/cloud/gettingStartedWeb.php example works with the new template. Currently the JS spits out these errors, apparently for some values are not being passed by the JavaScriptBuilderElement:
Uncaught SyntaxError: Unexpected token ';'
(index):234 Uncaught ReferenceError: fod is not defined
at window.onload ((index):234:9)
Contributor
|
The above is resolved with the latest commit, the only thing we need to ensure is that composer is installing this javascript-template dependency fine. Either using some hooks or otherwise let's convert it into a composer package of its own |
Contributor
|
updated changes are in #26 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.