New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Download option disappears on time-series colour change #154

Open
ghost opened this Issue Dec 16, 2015 · 2 comments

Comments

Projects
None yet
1 participant
@ghost

ghost commented Dec 16, 2015

Hello,

I've been using the JS-Client that's bundled with the SOS server, and I noticed that after a sensor has been selected, and we're looking at the time-series line plot, the "download as csv" option disappears after the colour of the time-series has been changed.

So, if the '''(i)''' button is pressed before colour change, there are the first/last value/times and the download option. After the colour change, only the first/last value/times are shown and no download option.

I saw the version-info.txt file in the library folder, hope this helps:

General Infos:
==============
project = 52North Client Implementation (restful-timeseries-client)
version = 1.0.0
builddate = 2015-11-02 04:18:24+0000

Subversion Infos:
=================
repository = ${git.repository}
path = origin/develop
revision = 2a077cd5922a22f1f932a3f80785cc01c6916c23
lastCommitMessage = Merge pull request #150 from 52North/master
lastCommitDate = 2015-10-27 15:45:18+0000

Thanks,
David

@justb4

This comment has been minimized.

justb4 commented Jul 20, 2016

Confirmed: found exactly the same behaviour, Download option disappears on time-series colour change in the js-sensorweb-client bundled in sensorweb-sos 4.3.7 downloaded as 484-52n-sensorweb-sos-bundle-4-3-7.

@justb4

This comment has been minimized.

justb4 commented Jul 20, 2016

Dived deeper: appears that after an update event timeseries:changeStyle via https://github.com/52North/js-sensorweb-client/blob/develop/src/main/js/controller/legendController.js the update for the refValues are not propagated or available from https://github.com/52North/js-sensorweb-client/blob/develop/src/main/js/models/timeseries.js (TImeseries object cloning issue?) during update in the template https://github.com/52North/js-sensorweb-client/blob/develop/src/main/webapp/templates/legend-entry.html in the {{#referenceValues}} there. See also this screenshot, the div for additionalLegendEntry has disappeared in the entry noiseavg whose color was changed to yellow.:

jsclient-dl-after-color-ch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment