Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the synchronous implementation of the WPS client #3

Merged
merged 13 commits into from Jun 14, 2019

Conversation

Projects
None yet
2 participants
@Mehigh17
Copy link
Collaborator

commented Jun 13, 2019

This should be a first preview of the WPS synchronous client. It offers two methods for getting the result, raw as-is and documented to the result type specified in the standard with the value deserialized to the generic type. Regarding the tests, the http client message handler has been mocked using Moq to remove the need of an online WPS server.

@Mehigh17 Mehigh17 requested a review from bpross-52n Jun 13, 2019

@Mehigh17 Mehigh17 self-assigned this Jun 13, 2019

@bpross-52n
Copy link
Member

left a comment

Looks fine, jts that I again got a failing test (must be my computer :D)
The test SerializeGetCapabilitiesRequest_ValidRequestGiven_ShouldPass fails. It seems that the GetCapabilities request is serialized with a version attribute. That is the only request that doesn't have that attribute however... Instead it can have acceptVersions elements.

@Mehigh17

This comment has been minimized.

Copy link
Collaborator Author

commented Jun 14, 2019

Looks fine, jts that I again got a failing test (must be my computer :D)
The test SerializeGetCapabilitiesRequest_ValidRequestGiven_ShouldPass fails. It seems that the GetCapabilities request is serialized with a version attribute. That is the only request that doesn't have that attribute however... Instead it can have acceptVersions elements.

That is my error, I removed a test session on my end and didn't notice it and I let it slip by. Regarding the implementation on this request indeed it was a little off to the standard, I inherited RequestBase for a temporary workaround and forgot about it. Should be all good now.

@Mehigh17 Mehigh17 requested a review from bpross-52n Jun 14, 2019

@bpross-52n
Copy link
Member

left a comment

All good!

@bpross-52n bpross-52n merged commit ebf30aa into 52North:develop Jun 14, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.