New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SimpleCDN produces incorrect URLs with latest Wicket 1.5-SNAPSHOT #35

Closed
mattbrictson opened this Issue Aug 29, 2012 · 1 comment

Comments

Projects
None yet
1 participant
@mattbrictson
Copy link
Contributor

mattbrictson commented Aug 29, 2012

fiftyfive/wicket/resource/SimpleCDNTestPage-expected.html expected:
<...pe="text/css" href="[//abc.cloudfront.net/wicket/resource/fiftyfive.wicket.resource.SimpleCDNTestPage/test.css" /> <script type="text/javascript" src="//abc.cloudfront.net/wicket/resource/fiftyfive.wicket.resource.SimpleCDNTestPage/test.js"></script> </head> <body>   <img src="]//abc.cloudfront.net...>
but was:
<...pe="text/css" href="[../..//abc.cloudfront.net/wicket/resource/fiftyfive.wicket.resource.SimpleCDNTestPage/test.css" /> <script type="text/javascript" src="../..//abc.cloudfront.net/wicket/resource/fiftyfive.wicket.resource.SimpleCDNTestPage/test.js"></script> </head> <body>   <img src="../..]//abc.cloudfront.net...>
@mattbrictson

This comment has been minimized.

Copy link
Contributor

mattbrictson commented Sep 1, 2012

There are actually two issues here:

Wicket does not understand scheme-less URLs that start with "//". Fixing this would require enhancements to Wicket's Url, UrlRenderer, and perhaps other classes. Until recently, scheme-less URLs would be rendered anyway, but this was more of a fluke. Now Wicket is more strict in parsing and normalizing URLs and doesn't allow this format. The changes were probably due to Wicket-4645.

SimpleCDNTest is also failing because absolute URLs generated by WicketTester have also apparently changed recently. This should be an easy fix: I just need to update the expected HTML output in the tests to match.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment