Skip to content
This repository was archived by the owner on Apr 26, 2024. It is now read-only.

Conversation

@katspaugh
Copy link
Member

@katspaugh katspaugh commented May 4, 2021

Closes #128.

Sorting doesn't work if you don't pass onHeaderClick, so no need to show the arrow icon in this case.

Screenshot 2021-05-04 at 10 54 28

@github-actions
Copy link

github-actions bot commented May 4, 2021

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

@ghost
Copy link

ghost commented May 4, 2021

Travis automatic deployment:
https://pr129--safereactcomponents.review.gnosisdev.com

@katspaugh katspaugh requested review from alongoni and nicosampler May 4, 2021 14:58
Copy link
Contributor

@alongoni alongoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@katspaugh katspaugh merged commit e121394 into development May 5, 2021
@katspaugh katspaugh deleted the fix-table branch May 5, 2021 07:35
@dasanra dasanra mentioned this pull request Jul 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Table: don't show arrows if no sorting function provided

3 participants