The same records are duplicated in the addressbook after the first importing

[liliya-soroka]

Description

The same records are duplicated in the addressbook after the first importing
( It's especially visiable during importing from mobile app, but I have the same duplication problem after importing just exported from web file, but only one time)

Environment

• Browser:Chrome
• Wallet: MetaMask
• Safe:
• Environment:
  • staging (rinkeby)

Steps to reproduce

1st case:

1. Go to Addressbook on staging

2. Export addressbook

3. Import just exported file
   Current result: The records are duplicated

4. try to import one more time
   Current result: No duplications one more time only already duplicated records are displayed

2nd case

1. Export addressbook from web
2. Import addressbook to the mobile
3. Export addressbook on mobile
4. Import to the web
   Current result: Duplications appears the same way as in the case above , but only one time. If you try to import it again no more new duplications

Expected result

The same records should not be duplicated, instead of it they should be updated

Screenshots

[liliya-soroka]

@katspaugh and @DmitryBespalov , I think we need PO input to prioritize it properly.
The issue may be more visible after the mobile address book release.

[DiogoSoaress]

I don't seem to be able to reproduce it @liliya-soroka. Can you check it again please? In Staging as in Dev, it is behaving as expected.

[liliya-soroka]

I was able to reproduce the issue on prod after unified app deployment

Not all records are duplicated. I am assuming that it is actual only for some type of the records (most of our users will have such records in the prod app, because I tried it on BSC network. The network was added this year )

[katspaugh]

Related to checksummed vs non-checksummed addresses maybe?

[liliya-soroka]

The addresses look similar on UI and in csv file ( checksummed)

[katspaugh]

But the already stored ones might be not checksummed.

[liliya-soroka]

Note: The issue was on prod before migration to unified app

[DmitryBespalov]

this was by design in the web app, i.e. the implementation deliberately did not handle duplicated records.

When implemented on mobile I think we handle those (skip them)