Skip to content
This repository was archived by the owner on Nov 10, 2023. It is now read-only.

Conversation

@katspaugh
Copy link
Member

@katspaugh katspaugh commented Nov 15, 2021

What it solves

Partially resolves #2837
Resolves #2999

How this PR fixes it

Instead of using a fixed gas price on xDai, request it from the blockchain.

I've done the same for Arbitrum, as it's recommended in their docs.

How to test it

  • Create a tx on xDai
  • Check the gasPrice in the advanced settings

Same on Arbitrum.

Screenshot

Screenshot 2021-11-15 at 17 30 57

@github-actions
Copy link

CLA Assistant Lite All Contributors have signed the CLA.

url: `https://ethgasstation.info/json/ethgasAPI.json?api-key=${ETHGASSTATION_API_KEY}`,
gasParameter: 'fast',
gweiFactor: '1e8',
},
Copy link
Member Author

@katspaugh katspaugh Nov 15, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also removed this from the Rinkeby config. Etherscan should be more than enough.

@github-actions
Copy link

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 3 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

@github-actions
Copy link

github-actions bot commented Nov 15, 2021

@github-actions
Copy link

E2E Tests Failed
Check the results here: https://github.com/gnosis/safe-react-e2e-tests/actions/runs/1463167013

Failed tests:

  • ❌ Safe Balances Safe Balances

@coveralls
Copy link

Pull Request Test Coverage Report for Build 1463142245

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 31.68%

Totals Coverage Status
Change from base Build 1462240983: 0.0%
Covered Lines: 2985
Relevant Lines: 8383

💛 - Coveralls

@francovenica
Copy link
Contributor

Safe I used:
https://pr2997--safereact.review-safe.gnosisdev.com/app/xdai:0xB8d760a90a5ed54D3c2b3EFC231277e99188642A/transactions/queue

The tx still is not estimating enough for a tx. This is a "Send funds" tx with 1 owner policy
image

and of course it ends up failing
image

Should we bump up by a % every tx?

@francovenica
Copy link
Contributor

francovenica commented Nov 16, 2021

Update:
In the previous comment the tx failed because of the gas limit, that is a known issue in xdai and is not part of this ticket.
I was told that the ticket is exclusive for the gasPrice.
So the gas price is not fixed in "1" anymore, is actually being estimated.
image

Looks good to me

@katspaugh katspaugh merged commit 3582d6f into dev Nov 17, 2021
@katspaugh katspaugh deleted the fix-xdai branch November 17, 2021 08:33
@github-actions github-actions bot locked and limited conversation to collaborators Nov 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Gas limit estimation on xDAI is not working xDai: Lack of GAS to execute the tx safely

5 participants