From 1942a3724359b9bc6bd35aa9cdf40964a1d234f9 Mon Sep 17 00:00:00 2001 From: Daniel Sanchez Date: Tue, 23 Nov 2021 16:11:50 +0100 Subject: [PATCH 1/2] Remove unused env vars from .env example file --- .env.example | 6 ------ .github/workflows/deploy.yml | 1 - .github/workflows/release-mainnet-desktop.yml | 1 - 3 files changed, 8 deletions(-) diff --git a/.env.example b/.env.example index d52451e91e..1b318d4386 100644 --- a/.env.example +++ b/.env.example @@ -1,6 +1,3 @@ -# You can leave this empty for rinkeby or use "mainnet" -REACT_APP_NETWORK= - # For all environments REACT_APP_GOOGLE_ANALYTICS= REACT_APP_INFURA_TOKEN= @@ -23,9 +20,6 @@ REACT_APP_LATEST_SAFE_VERSION= # Leave it untouched, version will set using dotenv-expand REACT_APP_APP_VERSION=$npm_package_version -# For Apps -REACT_APP_GNOSIS_APPS_URL=https://safe-apps.staging.gnosisdev.com - # Contracts Addresses REACT_APP_SPENDING_LIMIT_MODULE_ADDRESS=0x9e9Bf12b5a66c0f0A7435835e0365477E121B110 diff --git a/.github/workflows/deploy.yml b/.github/workflows/deploy.yml index dcd7524dc7..614f8d1502 100644 --- a/.github/workflows/deploy.yml +++ b/.github/workflows/deploy.yml @@ -18,7 +18,6 @@ env: STAGING_BUCKET_NAME: ${{ secrets.STAGING_BUCKET_NAME }} REACT_APP_SENTRY_DSN: ${{ secrets.SENTRY_DSN_MAINNET }} REACT_APP_GOOGLE_ANALYTICS: ${{ secrets.REACT_APP_GOOGLE_ANALYTICS_ID_MAINNET }} - REACT_APP_GNOSIS_APPS_URL: ${{ secrets.REACT_APP_GNOSIS_APPS_URL_PROD }} REACT_APP_ETHERSCAN_API_KEY: ${{ secrets.REACT_APP_ETHERSCAN_API_KEY }} REACT_APP_ETHGASSTATION_API_KEY: ${{ secrets.REACT_APP_ETHGASSTATION_API_KEY }} diff --git a/.github/workflows/release-mainnet-desktop.yml b/.github/workflows/release-mainnet-desktop.yml index 23aa8f1a85..9f1ef4cc38 100644 --- a/.github/workflows/release-mainnet-desktop.yml +++ b/.github/workflows/release-mainnet-desktop.yml @@ -7,7 +7,6 @@ env: REACT_APP_FORTMATIC_KEY: ${{ secrets.REACT_APP_FORTMATIC_KEY }} REACT_APP_INFURA_TOKEN: ${{ secrets.REACT_APP_INFURA_TOKEN }} REACT_APP_PORTIS_ID: ${{ secrets.REACT_APP_PORTIS_ID }} - REACT_APP_GNOSIS_APPS_URL: ${{ secrets.REACT_APP_GNOSIS_APPS_URL_PROD }} REACT_APP_INTERCOM_ID: ${{ secrets.REACT_APP_INTERCOM_ID }} REACT_APP_IPFS_GATEWAY: ${{ secrets.REACT_APP_IPFS_GATEWAY }} jobs: From e4fac5f246bb753e3df87f4ba50d793055dbed0c Mon Sep 17 00:00:00 2001 From: Daniel Sanchez Date: Tue, 23 Nov 2021 16:15:44 +0100 Subject: [PATCH 2/2] Update README for unified version --- README.md | 18 +++--------------- 1 file changed, 3 insertions(+), 15 deletions(-) diff --git a/README.md b/README.md index f02d50f6ed..10f6e134e0 100644 --- a/README.md +++ b/README.md @@ -58,18 +58,12 @@ Install dependencies for the project: yarn install ``` -To use the Rinkeby services: +To launch the app with all configured chains: ``` yarn start ``` -If you prefer using the Mainnet ones: - -``` -yarn start-mainnet -``` - If you prefer to use Docker: ``` @@ -78,18 +72,12 @@ docker-compose build && docker-compose up ### Building -For Rinkeby: +Te get a complete bundle using the current configuration use: ``` yarn build ``` -For Mainnet: - -``` -yarn build-mainnet -``` - ## Running the tests To run the tests: @@ -113,7 +101,7 @@ yarn lint:fix The code is deployed to a testing website automatically on each push via a GitHub Action. The GitHub Action will create a new subdomain and post the link as a comment in the PR. -When pushing to the `main` branch, the code will be automatically deployed to [staging](https://safe-team-rinkeby.staging.gnosisdev.com/). +When pushing to the `main` branch, the code will be automatically deployed to [staging](https://safe-team.staging.gnosisdev.com/). ### Production