Skip to content
This repository was archived by the owner on Nov 10, 2023. It is now read-only.

Conversation

@katspaugh
Copy link
Member

What it solves

Resolves #3102

How this PR fixes it

If networks mismatch, it says "Your wallet is connected to a wrong chain" in the error message.

@github-actions
Copy link

github-actions bot commented Dec 3, 2021

CLA Assistant Lite All Contributors have signed the CLA.

@github-actions
Copy link

github-actions bot commented Dec 3, 2021

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

@coveralls
Copy link

coveralls commented Dec 3, 2021

Pull Request Test Coverage Report for Build 1545635602

  • 0 of 3 (0.0%) changed or added relevant lines in 1 file are covered.
  • 793 unchanged lines in 63 files lost coverage.
  • Overall coverage decreased (-0.2%) to 32.458%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/components/TransactionFailText/index.tsx 0 3 0.0%
Files with Coverage Reduction New Missed Lines %
src/components/AppLayout/Header/components/ProviderDetails/UserDetails.tsx 1 0%
src/components/AppLayout/Sidebar/SafeHeader/index.tsx 1 0%
src/logic/currencyValues/store/reducer/currencyValues.ts 1 70.0%
src/logic/safe/transactions/api/fetchSafeTransaction.ts 1 50.0%
src/logic/tokens/api/fetchErc20AndErc721AssetsList.ts 1 50.0%
src/routes/CreateSafePage/steps/SelectWalletAndNetworkStep.tsx 1 91.67%
src/routes/LoadSafePage/LoadSafePage.tsx 1 91.11%
src/routes/LoadSafePage/steps/SelectNetworkStep.tsx 1 93.33%
src/routes/safe/components/AddressBook/utils.ts 1 95.92%
src/routes/safe/components/Settings/SpendingLimit/InfoDisplay/AddressInfo.tsx 1 14.29%
Totals Coverage Status
Change from base Build 1535243036: -0.2%
Covered Lines: 3086
Relevant Lines: 8468

💛 - Coveralls

@github-actions
Copy link

github-actions bot commented Dec 3, 2021

Deployment links

🟠 Safe Rinkeby Safe Mainnet 🟣 Safe Polygon 🟡 Safe BSC Safe Arbitrum 🟢 Safe xDai

@github-actions
Copy link

github-actions bot commented Dec 3, 2021

E2E Tests Failed
Check the results here: https://github.com/gnosis/safe-react-e2e-tests/actions/runs/1545657812

Failed tests:

  • ❌ Add an existing safe Add an existing safe
  • ❌ Address book Address book
  • ❌ Safe Apps List Safe Apps List
  • ❌ Read-only transaction creation and review Create and review a Send Funds transaction

{isGranted ? (
<>This transaction will most likely fail. {errorMessage}</>
) : isWrongChain ? (
<>Your wallet is connected to a wrong chain.</>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Your wallet is connected to the wrong chain."

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed, thanks!

@francovenica
Copy link
Contributor

Looks good to me.

I used an app called Mesa.eth
Used a rinkeby safe, enter into the WC app, connected with Mesa.eth and before starting a tx I changed the MM extension network to Mainnet.
I see the message regarding been in the wrong network

Tried to switch back to the Correct network (rinkeby in this case) and tx worked as expected

Snapshot:
image

@katspaugh katspaugh merged commit 550327c into dev Dec 9, 2021
@katspaugh katspaugh deleted the wrong-chain-error branch December 9, 2021 08:39
@github-actions github-actions bot locked and limited conversation to collaborators Dec 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

WalletConnect: unclear error message when wallet is connected to a diff chain

5 participants