Skip to content
This repository was archived by the owner on Nov 10, 2023. It is now read-only.

Conversation

@katspaugh
Copy link
Member

What it solves

Resolves #3124

How this PR fixes it

Restores the ability to configure a fixed gas price on config-service.

How to test it

  • Open an xDai Safe
  • Make a tx
  • Gas price should be always 1

Screenshots

Screenshot 2021-12-07 at 15 16 22

@github-actions
Copy link

github-actions bot commented Dec 7, 2021

CLA Assistant Lite All Contributors have signed the CLA.

@mmv08
Copy link
Contributor

mmv08 commented Dec 7, 2021

did you report the issue with eth_gasPrice to devops/openethereum team?

@katspaugh katspaugh requested a review from iamacook December 7, 2021 14:24
@katspaugh
Copy link
Member Author

@mikheevm will do it now, thank you!

@github-actions
Copy link

github-actions bot commented Dec 7, 2021

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 1 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

@github-actions
Copy link

github-actions bot commented Dec 7, 2021

Deployment links

🟠 Safe Rinkeby Safe Mainnet 🟣 Safe Polygon 🟡 Safe BSC Safe Arbitrum 🟢 Safe xDai

@coveralls
Copy link

coveralls commented Dec 7, 2021

Pull Request Test Coverage Report for Build 1550083567

  • 2 of 8 (25.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.004%) to 32.35%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/config/index.ts 1 4 25.0%
src/logic/wallets/ethTransactions.ts 0 3 0.0%
Totals Coverage Status
Change from base Build 1548873437: -0.004%
Covered Lines: 3081
Relevant Lines: 8468

💛 - Coveralls

@github-actions
Copy link

github-actions bot commented Dec 7, 2021

E2E Tests Failed
Check the results here: https://github.com/gnosis/safe-react-e2e-tests/actions/runs/1550119618

Failed tests:

  • ❌ Add an existing safe Add an existing safe
  • ❌ Address book Address book
  • ❌ Safe Apps List Safe Apps List
  • ❌ Read-only transaction creation and review Create and review a Send Funds transaction

@katspaugh
Copy link
Member Author

@francovenica to test, please use this link:

https://pr3128--safereact.review-safe.gnosisdev.com/app/xdai#prod

(Add #prod to the URL and refresh to use the production CGW that has xDai)

@katspaugh katspaugh force-pushed the fix-fixed-gas-price branch from 65744e7 to 6f8f1ff Compare December 7, 2021 15:21
@francovenica
Copy link
Contributor

Gas price is fixed at "1" again.
Is read properly in the MM pop up
Can still be edited with no issues.

Looks good to me

image

@katspaugh katspaugh merged commit 5a246e2 into dev Dec 7, 2021
@katspaugh katspaugh deleted the fix-fixed-gas-price branch December 7, 2021 16:59
@github-actions github-actions bot locked and limited conversation to collaborators Dec 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Overestimating gas price on xDai

6 participants