This repository was archived by the owner on Nov 10, 2023. It is now read-only.
Allow certificates errors only for the Electron-created back end #3208
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before, the Electron app would trust any invalid certificate. With this commit, only the Electron-created backend at https://localhost:5000 can have an invalid (self-signed) certificate.
|
CLA Assistant Lite All Contributors have signed the CLA. |
Pull Request Test Coverage Report for Build 1607527724
💛 - Coveralls |
Member
|
Thank you for all the PRs @Vasco-jofra! |
dasanra
approved these changes
Dec 22, 2021
Collaborator
dasanra
left a comment
dasanra
left a comment
There was a problem hiding this comment.
Thank you for all your three contributions @Vasco-jofra
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it solves
This commit ensures that the Electron app allows only the Electron-created backend at https://localhost:5000 to have an invalid (self-signed) certificate.
How this PR fixes it
Instead of appending
'ignore-certificate-errors'to the command line, catch certificate errors and check the associated origin.Reference: https://www.electronjs.org/docs/latest/api/app#event-certificate-error