Skip to content
This repository was archived by the owner on Nov 10, 2023. It is now read-only.

Conversation

@katspaugh
Copy link
Member

What it solves

Resolves #3288

How this PR fixes it

Adds nowrap to the modal header and and overflow: hidden to the ChainIndicator

Screenshots

Screenshot 2022-01-11 at 17 22 00

Screenshot 2022-01-11 at 17 22 10

When there's not enough space, the ChainIndicator will be cut off:
Screenshot 2022-01-11 at 17 22 05

@katspaugh katspaugh requested a review from iamacook January 11, 2022 16:26
@github-actions
Copy link

CLA Assistant Lite All Contributors have signed the CLA.

@github-actions
Copy link

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

Copy link
Contributor

@iamacook iamacook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🔥

@github-actions
Copy link

Deployment links

🟠 Safe Rinkeby Safe Mainnet 🟣 Safe Polygon 🟡 Safe BSC Safe Arbitrum 🟢 Safe xDai

@coveralls
Copy link

Pull Request Test Coverage Report for Build 1683504875

  • 1 of 2 (50.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.002%) to 32.422%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/components/Modal/index.tsx 1 2 50.0%
Totals Coverage Status
Change from base Build 1682592319: 0.002%
Covered Lines: 3112
Relevant Lines: 8549

💛 - Coveralls

@github-actions
Copy link

E2E Tests Failed
Check the results here: https://github.com/gnosis/safe-react-e2e-tests/actions/runs/1683545516

Failed tests:

  • ❌ Safe Apps List Safe Apps List

@francovenica
Copy link
Contributor

This fixes the issue of the X fine, but I'm not sure about just cutting the chain name.
I'll be ok closing this as resolved, but I'd create a ticket for the designer to think of a way to put the full name of the network
cc @johannesmoormann

@katspaugh katspaugh merged commit 10c0513 into dev Jan 12, 2022
@katspaugh katspaugh deleted the fix-modal-css branch January 12, 2022 20:57
@github-actions github-actions bot locked and limited conversation to collaborators Jan 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix "Approve transaction" modal for long network names

5 participants