Skip to content
This repository was archived by the owner on Nov 10, 2023. It is now read-only.

Conversation

@iamacook
Copy link
Contributor

@iamacook iamacook commented Jan 12, 2022

What it solves

Resolves #3292

How this PR fixes it

Existing transactions in the history payload are no longer cached and instead overwritten with the 'fresh' data instead.

How to test it

This is trivial to test, but the current cancel bug that we are experiencing is a good reference to use: (aka no manul refresh needed)

  1. Create a transaction and execute it immediately on a 1/? Safe.
  2. Copy the (deeplink) URL and open it immediately in another tab. The status should show that it is cancelled.
  3. Remain in the new tab and observe that after the automatic polling, the status should now update.

Note: we were able to reproduce this on production Rinkeby on a 1/1 Safe.

@github-actions
Copy link

CLA Assistant Lite All Contributors have signed the CLA.

@github-actions
Copy link

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

@github-actions
Copy link

Deployment links

🟠 Safe Rinkeby Safe Mainnet 🟣 Safe Polygon 🟡 Safe BSC Safe Arbitrum 🟢 Safe xDai

@coveralls
Copy link

Pull Request Test Coverage Report for Build 1687347576

  • 0 of 10 (0.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.008%) to 32.375%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/logic/safe/store/reducer/gatewayTransactions.ts 0 10 0.0%
Totals Coverage Status
Change from base Build 1683593087: 0.008%
Covered Lines: 3116
Relevant Lines: 8564

💛 - Coveralls

@github-actions
Copy link

E2E Tests Failed
Check the results here: https://github.com/gnosis/safe-react-e2e-tests/actions/runs/1687373620

Failed tests:

  • ❌ Read-only transaction creation and review Read-only transaction creation and review

@iamacook iamacook requested a review from katspaugh January 12, 2022 17:49
@francovenica
Copy link
Contributor

Looks good to me. The tx status in the new tab was updated.

Note: "Send funds" tx will show the pending status and the "needs execution" status in the new tab. "Contract interactions" tx will show the cancelled status in both tabs until it updates. Not a bug, just a curious behavior

@iamacook iamacook merged commit a857f63 into dev Jan 18, 2022
@iamacook iamacook deleted the remove-history-tx-payload-caching branch January 18, 2022 08:02
@github-actions github-actions bot locked and limited conversation to collaborators Jan 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Historical transactions are being cached

6 participants