This repository was archived by the owner on Nov 10, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 360
Do not cache transactions from history payload #3293
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Assistant Lite All Contributors have signed the CLA. |
ESLint Summary View Full Report
Report generated by eslint-plus-action |
Deployment links
|
Pull Request Test Coverage Report for Build 1687347576
💛 - Coveralls |
|
E2E Tests Failed Failed tests:
|
katspaugh
reviewed
Jan 12, 2022
katspaugh
reviewed
Jan 12, 2022
katspaugh
approved these changes
Jan 14, 2022
Contributor
|
Looks good to me. The tx status in the new tab was updated. Note: "Send funds" tx will show the pending status and the "needs execution" status in the new tab. "Contract interactions" tx will show the cancelled status in both tabs until it updates. Not a bug, just a curious behavior |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it solves
Resolves #3292
How this PR fixes it
Existing transactions in the history payload are no longer cached and instead overwritten with the 'fresh' data instead.
How to test it
This is trivial to test, but the current cancel bug that we are experiencing is a good reference to use: (aka no manul refresh needed)
Note: we were able to reproduce this on production Rinkeby on a 1/1 Safe.