Fix: xDai -> Gnosis Chain #3304
Conversation
|
CLA Assistant Lite All Contributors have signed the CLA. |
ESLint Summary View Full Report
Report generated by eslint-plus-action |
Deployment links
|
|
E2E Tests Failed Failed tests:
|
iamacook
left a comment
iamacook
left a comment
There was a problem hiding this comment.
Looking good. I adjusted the deployment script to reflect the changes too
|
I've had a follow up thought to this. We should probably also redirect |
|
True dat. |
src/routes/index.tsx
Outdated
| key={chainId} | ||
| path={route} | ||
| // /xdai also sets chainId correctly | ||
| path={chainId === CHAIN_ID.GNOSIS_CHAIN ? [route, '/xdai'] : route} |
There was a problem hiding this comment.
I would add a redirect instead of this
|
The MM wallet is no longer the deafult in this PR. it has soemthing to do with the name change? The loader doesn't accept an existing xDai safe |
|
I'm getting these constantly as I try to load a recently created safe
|
|
@francovenica, in order to test this you should be using the production CGW |
|
@iamacook yes, you were right, the issues loading an existing safe and loading a recently created safe don't happen with the CGW switch being on. So those are fine I still have the issue with the modal, and is something that only happens with the Gnosis Chain. For the other networks MM is still the 1st option in the modal |
I wouldn't be concerned about the order of wallets. I added a draft copy of Gnosis Change to the staging environment for testing. The most important thing is that the redirection works. All we now need to do is rename xDai on production and all should work as it does in production. |
|
|
||
| export const loadChains = async () => { | ||
| const { results = [] } = await getChainsConfig(GATEWAY_URL, { limit: 100 }) | ||
| const { results = [] } = await getChainsConfig(GATEWAY_URL) |
There was a problem hiding this comment.
Also removed limit: 100.
|
The renaming looks good to me. Check the prefixes, copy paste, the going to the block explorer. Created new safes and loaded safes created while it was xdai. Note: The issue 3305 is present here, doesn't have anything to do with the naming, but prevented me for executing some tx. |
What it solves
Resolves #3200
How this PR fixes it
XDAItoGNOSIS_CHAINin theCHAIN_IDenum/app/xdai:0x...to/app/gno:0x...setChainFromUrlso that any redirects happen only from the router/app/xdaito redirect to/app/gnoshortNamesas 'root' routes that set thechainIdon app loadHow to test it
gnowithxdaiin the URL – it should redirect back togno