This repository was archived by the owner on Nov 10, 2023. It is now read-only.
fix: Disable queued Tx interaction while replacement Tx is pending #3405
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Assistant Lite All Contributors have signed the CLA. |
ESLint Summary View Full Report
Report generated by eslint-plus-action |
|
E2E Tests Failed Failed tests:
|
Pull Request Test Coverage Report for Build 1789441569
💛 - Coveralls |
usame-algan
force-pushed
the
pending-tx-replacement
branch
from
2dc9611 to
a6082c3
Compare
iamacook
reviewed
Feb 2, 2022
Contributor
iamacook
left a comment
iamacook
left a comment
There was a problem hiding this comment.
Nice selector! Just a couple things
iamacook
reviewed
Feb 2, 2022
|
|
||
| useEffect(() => { | ||
| if (activeHover && activeHover !== transaction.id) { | ||
| if ((activeHover && activeHover !== transaction.id) || (!isPending && nonce === pendingTxNonce)) { |
Contributor
There was a problem hiding this comment.
If they are both undefined (nonce and pendingTxNonce) this condition will pass. You should check that they both exist as well.
usame-algan
force-pushed
the
pending-tx-replacement
branch
from
4f3f253 to
b7da931
Compare
usame-algan
force-pushed
the
pending-tx-replacement
branch
from
b7da931 to
ab4be46
Compare
iamacook
reviewed
Feb 3, 2022
|
|
||
| setTx(transaction) | ||
| }, [activeHover, transaction]) | ||
| }, [activeHover, transaction, isPending, nonce, pendingTxNonce]) |
Contributor
There was a problem hiding this comment.
You need to add isReplacementTxPending as a dependancy.
Contributor
Author
There was a problem hiding this comment.
Good catch! Fixed it
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it solves
Resolves #3359
How this PR fixes it
We now take the pending state of a transaction into account to decide whether their replacement transaction should be disabled or not
How to test it
Screenshots