This repository was archived by the owner on Nov 10, 2023. It is now read-only.
Feature: display ENS name in connected wallet info #3409
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Assistant Lite All Contributors have signed the CLA. |
ESLint Summary View Full Report
Report generated by eslint-plus-action |
Pull Request Test Coverage Report for Build 1783510560
💛 - Coveralls |
|
E2E Tests Failed Failed tests:
|
iamacook
approved these changes
Feb 2, 2022
| <KeyRing circleSize={75} dotRight={25} dotSize={25} dotTop={50} hideDot keySize={30} mode="warning" /> | ||
| )} | ||
| </Row> | ||
| <Block className={classes.ens} justify="center"> |
Contributor
There was a problem hiding this comment.
Maybe this should be conditional?
usame-algan
approved these changes
Feb 2, 2022
src/components/AppLayout/Header/components/ProviderInfo/ProviderAccessible.tsx
Show resolved
Hide resolved
Contributor
|
Looks good to me: No ENS: (nothing broke) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it solves
Resolves #3255
How this PR fixes it
If present, adds a reverse ENS name to the connected wallet popup.
How to test it
Screenshots