diff --git a/.github/workflows/codeql-analysis.yml b/.github/workflows/codeql-analysis.yml new file mode 100644 index 0000000000..9aa698fa10 --- /dev/null +++ b/.github/workflows/codeql-analysis.yml @@ -0,0 +1,70 @@ +# For most projects, this workflow file will not need changing; you simply need +# to commit it to your repository. +# +# You may wish to alter this file to override the set of languages analyzed, +# or to provide custom queries or build logic. +# +# ******** NOTE ******** +# We have attempted to detect the languages in your repository. Please check +# the `language` matrix defined below to confirm you have the correct set of +# supported CodeQL languages. +# +name: "CodeQL" + +on: + push: + branches: [ dev ] + pull_request: + # The branches below must be a subset of the branches above + branches: [ dev ] + schedule: + - cron: '37 9 * * 6' + +jobs: + analyze: + name: Analyze + runs-on: ubuntu-latest + permissions: + actions: read + contents: read + security-events: write + + strategy: + fail-fast: false + matrix: + language: [ 'javascript' ] + # CodeQL supports [ 'cpp', 'csharp', 'go', 'java', 'javascript', 'python', 'ruby' ] + # Learn more about CodeQL language support at https://git.io/codeql-language-support + + steps: + - name: Checkout repository + uses: actions/checkout@v2 + + # Initializes the CodeQL tools for scanning. + - name: Initialize CodeQL + uses: github/codeql-action/init@v1 + with: + languages: ${{ matrix.language }} + # If you wish to specify custom queries, you can do so here or in a config file. + # By default, queries listed here will override any specified in a config file. + # Prefix the list here with "+" to use these queries and those in the config file. + # queries: ./path/to/local/query, your-org/your-repo/queries@main + + # Autobuild attempts to build any compiled languages (C/C++, C#, or Java). + # If this step fails, then you should remove it and run the build manually (see below) + - name: Autobuild + uses: github/codeql-action/autobuild@v1 + + # â„šī¸ Command-line programs to run using the OS shell. + # 📚 https://git.io/JvXDl + + # âœī¸ If the Autobuild fails above, remove it and uncomment the following three lines + # and modify them (or add more) to build your code if your project + # uses a compiled language + + #- run: | + # make bootstrap + # make release + + - name: Perform CodeQL Analysis + uses: github/codeql-action/analyze@v1 diff --git a/src/components/forms/validator.test.ts b/src/components/forms/validator.test.ts index 504b18cc10..a635081b4c 100644 --- a/src/components/forms/validator.test.ts +++ b/src/components/forms/validator.test.ts @@ -3,7 +3,6 @@ import { mustBeInteger, mustBeFloat, maxValue, - mustBeUrl, minValue, mustBeEthereumAddress, mustBeAddressHash, @@ -92,18 +91,6 @@ describe('Forms > Validators', () => { }) }) - describe('mustBeUrl validator', () => { - const MUST_BE_URL_ERR_MSG = 'Please, provide a valid url' - - it('Returns undefined for a valid url', () => { - expect(mustBeUrl('https://gnosis-safe.io')).toBeUndefined() - }) - - it('Returns an error message for an valid url', () => { - expect(mustBeUrl('gnosis-safe')).toEqual(MUST_BE_URL_ERR_MSG) - }) - }) - describe('maxValue validator', () => { const getMaxValueErrMsg = (maxValue: number): string => `Maximum value is ${maxValue}` diff --git a/src/components/forms/validator.ts b/src/components/forms/validator.ts index ddedf6a7bb..a18ac04818 100644 --- a/src/components/forms/validator.ts +++ b/src/components/forms/validator.ts @@ -34,17 +34,6 @@ export const mustBeInteger = (value: string): ValidatorReturnType => export const mustBeFloat = (value: string): ValidatorReturnType => value && Number.isNaN(Number(value)) ? 'Must be a number' : undefined -const regexQuery = - /^(?:(?:https?|ftp):\/\/)(?:\S+(?::\S*)?@)?(?:(?!(?:10|127)(?:\.\d{1,3}){3})(?!(?:169\.254|192\.168)(?:\.\d{1,3}){2})(?!172\.(?:1[6-9]|2\d|3[0-1])(?:\.\d{1,3}){2})(?:[1-9]\d?|1\d\d|2[01]\d|22[0-3])(?:\.(?:1?\d{1,2}|2[0-4]\d|25[0-5])){2}(?:\.(?:[1-9]\d?|1\d\d|2[0-4]\d|25[0-4]))|(?:(?:[a-z\u00a1-\uffff0-9]-*)*[a-z\u00a1-\uffff0-9]+)(?:\.(?:[a-z\u00a1-\uffff0-9]-*)*[a-z\u00a1-\uffff0-9]+)*(?:\.(?:[a-z\u00a1-\uffff]{2,}))\.?)(?::\d{2,5})?(?:[/?#]\S*)?$/i -const url = new RegExp(regexQuery) -export const mustBeUrl = (value: string): ValidatorReturnType => { - if (url.test(value)) { - return undefined - } - - return 'Please, provide a valid url' -} - export const minValue = (min: number | string, inclusive = true) => (value: string): ValidatorReturnType => {