Skip to content
This repository was archived by the owner on Nov 10, 2023. It is now read-only.

Conversation

@DiogoSoaress
Copy link
Contributor

What it solves

Resolves #3509

How this PR fixes it

Removes style that was suppressing row-gap in the last MUI accordion for no apparent reason

How to test it

Open a transaction deeplink view and the layout shall not be cramped anymore.

Screenshots

Screen Shot 2022-02-15 at 14 55 52

@github-actions
Copy link

CLA Assistant Lite All Contributors have signed the CLA.

@github-actions
Copy link

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

@DiogoSoaress
Copy link
Contributor Author

The removed style doesn't seem to be have any practical effect other than not cramping the last accordion content which I believe it's a leftover style. I've tested how it affects the layout and doesn't seem to have any negative impact.

@github-actions
Copy link

Deployment links

🟠 Rinkeby Mainnet 🟣 Polygon 🟡 BSC Arbitrum 🟢 Gnosis Chain

@coveralls
Copy link

Pull Request Test Coverage Report for Build 1847670315

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 33.492%

Totals Coverage Status
Change from base Build 1845972783: 0.0%
Covered Lines: 3228
Relevant Lines: 8613

💛 - Coveralls

@github-actions
Copy link

E2E Tests Failed
Check the results here: https://github.com/gnosis/safe-react-e2e-tests/actions/runs/1847721838

Failed tests:

  • ❌ Read-only transaction creation and review Read-only transaction creation and review
  • ❌ Safe Balances Safe Balances

@francovenica
Copy link
Contributor

Looks good now. thanks

@DiogoSoaress DiogoSoaress merged commit 0447103 into dev Feb 15, 2022
@DiogoSoaress DiogoSoaress deleted the fix-tx-detail-cramped branch February 15, 2022 16:23
@github-actions github-actions bot locked and limited conversation to collaborators Feb 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Delete spending limit - tx details values all cramped up

5 participants