This repository was archived by the owner on Nov 10, 2023. It is now read-only.
fix: always reset wallet on disconnect event
#3562
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Assistant Lite All Contributors have signed the CLA. |
iamacook
commented
Feb 23, 2022
| resetWalletState({ disconnected: true, walletName: PAIRING_MODULE_NAME }) | ||
| } | ||
|
|
||
| provider.wc.on('disconnect', onDisconnect) |
Contributor
Author
There was a problem hiding this comment.
When rejecting the pairing request, this fires.
ESLint Summary View Full Report
Report generated by eslint-plus-action |
Member
|
@iamacook , verified |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it solves
Resolves outdated pairing QR upon connection rejection.
How this PR fixes it
onDisconnectwas only being called when the provider was connected. If the user rejects a pairing request, the provider was!connectedand would therefore not reset the wallet, invalidating the QR code. Theconnectedflag has been removed.How to test it