Skip to content
This repository was archived by the owner on Nov 10, 2023. It is now read-only.

Conversation

@usame-algan
Copy link
Contributor

@usame-algan usame-algan commented Mar 4, 2022

What it solves

Relates to #3413

Resolves #3515 (comment)

How this PR fixes it

If no Beamer app id exists, the "Whats New" Button stays hidden and Beamer is not included.

How to test it

  1. Open the Safe app on production without a beamer app id in .env
  2. Observe that there is no "Whats new" Button in the sidebar
  3. Accept all cookies
  4. Observe that the console shows a Beamer app id missing warning

@github-actions
Copy link

github-actions bot commented Mar 4, 2022

CLA Assistant Lite All Contributors have signed the CLA.

@github-actions
Copy link

github-actions bot commented Mar 4, 2022

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

@coveralls
Copy link

Pull Request Test Coverage Report for Build 1933835969

  • 1 of 2 (50.0%) changed or added relevant lines in 2 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.005%) to 34.867%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/utils/beamer.ts 0 1 0.0%
Files with Coverage Reduction New Missed Lines %
src/utils/beamer.ts 1 0%
Totals Coverage Status
Change from base Build 1932713526: 0.005%
Covered Lines: 3364
Relevant Lines: 8718

💛 - Coveralls

@github-actions
Copy link

github-actions bot commented Mar 4, 2022

Deployment links

🟠 Rinkeby Mainnet 🟣 Polygon 🟡 BSC Arbitrum 🟢 Gnosis Chain

@github-actions
Copy link

github-actions bot commented Mar 4, 2022

E2E Tests Failed
Check the results here: https://github.com/gnosis/safe-react-e2e-tests/actions/runs/1933873624

Failed tests:

  • ❌ Add an existing safe Add an existing safe
  • ❌ Read-only transaction creation and review Read-only transaction creation and review
  • ❌ Safe Apps List Safe Apps List
  • ❌ Safe Balances Safe Balances

@usame-algan usame-algan merged commit 0e5c078 into dev Mar 7, 2022
@usame-algan usame-algan deleted the fix-beamer-load branch March 7, 2022 14:08
@github-actions github-actions bot locked and limited conversation to collaborators Mar 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants