This repository was archived by the owner on Nov 10, 2023. It is now read-only.
fix: Only hide first wallet if mobile pairing is enabled #3627
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Assistant Lite All Contributors have signed the CLA. |
ESLint Summary View Full Report
Report generated by eslint-plus-action |
Pull Request Test Coverage Report for Build 1945356973
💛 - Coveralls |
iamacook
reviewed
Mar 7, 2022
| // Hides first wallet in Onboard modal (pairing module) | ||
| useEffect(() => { | ||
| const style = document.createElement('style') | ||
| style.innerHTML = '.bn-onboard-modal-select-wallets li:first-of-type {display: none;}' |
Contributor
There was a problem hiding this comment.
Please extract this into a constant.
|
E2E Tests Failed Failed tests:
|
usame-algan
force-pushed
the
fix-hide-pairing
branch
from
6aa730f to
00ea436
Compare
Contributor
|
it seems that only the the GC was the one not supporting the pairing (or at least is the only network not showing the option to pair it). |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it solves
Resolves #3624
How this PR fixes it
Instead of normally importing the css within
PairingDetailsand leaving it there we now import it on mount and remove it once the component unmounts.Additional refactors
wrapInSuspensewas moved closer to the component that required it (PairingDetails)How to test it
Screenshot