Skip to content
This repository was archived by the owner on Nov 10, 2023. It is now read-only.

Conversation

@iamacook
Copy link
Contributor

What it solves

Comments made by @dasanra (#3640)

How this PR fixes it

Assets now use TokenType instead of the transaction-specific type.

@iamacook iamacook requested a review from dasanra March 11, 2022 09:27
@iamacook iamacook self-assigned this Mar 11, 2022
@github-actions
Copy link

CLA Assistant Lite All Contributors have signed the CLA.

name: string
symbol: string
type: TransactionTokenType
type: TokenType
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are checking that this is an asset.

onError={(error) => {
error.currentTarget.onerror = null
error.currentTarget.src = assetInfo.tokenType === TransactionTokenType.ERC721 ? NFTIcon : TokenPlaceholder
error.currentTarget.src = assetInfo.tokenType === TokenType.ERC721 ? NFTIcon : TokenPlaceholder
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This comes from an asset.

@github-actions
Copy link

github-actions bot commented Mar 11, 2022

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

@coveralls
Copy link

coveralls commented Mar 11, 2022

Pull Request Test Coverage Report for Build 1977068571

  • 0 of 1 (0.0%) changed or added relevant line in 1 file are covered.
  • 84 unchanged lines in 11 files lost coverage.
  • Overall coverage decreased (-0.2%) to 34.87%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/routes/safe/components/Transactions/TxList/TokenTransferAmount.tsx 0 1 0.0%
Files with Coverage Reduction New Missed Lines %
src/logic/tokens/api/fetchSafeCollectibles.ts 1 50.0%
src/utils/beamer.ts 2 0%
src/logic/safe/hooks/useLoadSafe.tsx 4 0%
src/logic/safe/hooks/useSafeScheduledUpdates.tsx 4 0%
src/logic/safe/store/actions/fetchSafe.ts 5 85.94%
src/logic/collectibles/store/actions/fetchCollectibles.ts 6 12.5%
src/logic/safe/store/actions/transactions/fetchTransactions/index.ts 6 0%
src/utils/googleAnalytics.ts 7 40.74%
src/logic/safe/store/actions/transactions/fetchTransactions/loadGatewayTransactions.ts 8 11.11%
src/logic/collectibles/sources/Gnosis.ts 15 7.89%
Totals Coverage Status
Change from base Build 1963767791: -0.2%
Covered Lines: 3375
Relevant Lines: 8770

💛 - Coveralls

@github-actions
Copy link

Deployment links

🟠 Rinkeby Mainnet 🟣 Polygon 🟡 BSC Arbitrum 🟢 Gnosis Chain

@github-actions
Copy link

E2E Tests Failed
Check the results here: https://github.com/gnosis/safe-react-e2e-tests/actions/runs/1968023571

Failed tests:

  • ❌ Add an existing safe Add an existing safe
  • ❌ Read-only transaction creation and review Read-only transaction creation and review
  • ❌ Safe Apps List Safe Apps List

@iamacook iamacook merged commit 87ed972 into dev Mar 14, 2022
@iamacook iamacook deleted the asset-token-types branch March 14, 2022 13:38
@github-actions github-actions bot locked and limited conversation to collaborators Mar 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants