From 016506b09c861a9e1976cf14d306f43bd6430a8c Mon Sep 17 00:00:00 2001
From: Diana Scharf <scharf.diana@googlemail.com>
Date: Sat, 7 Aug 2021 22:46:55 +0200
Subject: [PATCH 1/2] [DRAFT] Added Modifiable contract to set-able properties

---
 src/Entities/Contracts/Modifiable.php   | 10 ++++++++++
 src/Entities/Properties/Checkbox.php    |  3 ++-
 src/Entities/Properties/Date.php        |  5 +++--
 src/Entities/Properties/Email.php       |  4 +++-
 src/Entities/Properties/MultiSelect.php |  3 ++-
 src/Entities/Properties/Number.php      |  4 +++-
 src/Entities/Properties/People.php      |  3 ++-
 src/Entities/Properties/PhoneNumber.php |  4 +++-
 src/Entities/Properties/Relation.php    |  3 ++-
 src/Entities/Properties/Select.php      |  3 ++-
 src/Entities/Properties/Text.php        |  3 ++-
 src/Entities/Properties/Title.php       |  3 ++-
 src/Entities/Properties/Url.php         |  4 +++-
 13 files changed, 39 insertions(+), 13 deletions(-)
 create mode 100644 src/Entities/Contracts/Modifiable.php

diff --git a/src/Entities/Contracts/Modifiable.php b/src/Entities/Contracts/Modifiable.php
new file mode 100644
index 0000000..6e2095e
--- /dev/null
+++ b/src/Entities/Contracts/Modifiable.php
@@ -0,0 +1,10 @@
+<?php
+
+namespace FiveamCode\LaravelNotionApi\Entities\Contracts;
+
+use FiveamCode\LaravelNotionApi\Entities\Properties\Property;
+
+interface Modifiable
+{
+    public static function value($value): Property;
+}
\ No newline at end of file
diff --git a/src/Entities/Properties/Checkbox.php b/src/Entities/Properties/Checkbox.php
index 965dbd4..7d2db79 100644
--- a/src/Entities/Properties/Checkbox.php
+++ b/src/Entities/Properties/Checkbox.php
@@ -2,13 +2,14 @@
 
 namespace FiveamCode\LaravelNotionApi\Entities\Properties;
 
+use FiveamCode\LaravelNotionApi\Entities\Contracts\Modifiable;
 use FiveamCode\LaravelNotionApi\Exceptions\HandlingException;
 
 /**
  * Class Checkbox
  * @package FiveamCode\LaravelNotionApi\Entities\Properties
  */
-class Checkbox extends Property
+class Checkbox extends Property implements Modifiable
 {
 
     /**
diff --git a/src/Entities/Properties/Date.php b/src/Entities/Properties/Date.php
index f4e42ec..bf00773 100644
--- a/src/Entities/Properties/Date.php
+++ b/src/Entities/Properties/Date.php
@@ -3,14 +3,15 @@
 namespace FiveamCode\LaravelNotionApi\Entities\Properties;
 
 use DateTime;
-use FiveamCode\LaravelNotionApi\Entities\PropertyItems\RichDate;
 use FiveamCode\LaravelNotionApi\Exceptions\HandlingException;
+use FiveamCode\LaravelNotionApi\Entities\Contracts\Modifiable;
+use FiveamCode\LaravelNotionApi\Entities\PropertyItems\RichDate;
 
 /**
  * Class Date
  * @package FiveamCode\LaravelNotionApi\Entities\Properties
  */
-class Date extends Property
+class Date extends Property implements Modifiable
 {
 
     /**
diff --git a/src/Entities/Properties/Email.php b/src/Entities/Properties/Email.php
index e0520fa..bc87151 100644
--- a/src/Entities/Properties/Email.php
+++ b/src/Entities/Properties/Email.php
@@ -2,11 +2,13 @@
 
 namespace FiveamCode\LaravelNotionApi\Entities\Properties;
 
+use FiveamCode\LaravelNotionApi\Entities\Contracts\Modifiable;
+
 /**
  * Class Email
  * @package FiveamCode\LaravelNotionApi\Entities\Properties
  */
-class Email extends Property
+class Email extends Property implements Modifiable
 {
     /**
      * @param $email
diff --git a/src/Entities/Properties/MultiSelect.php b/src/Entities/Properties/MultiSelect.php
index 0a1dc30..d8339ad 100644
--- a/src/Entities/Properties/MultiSelect.php
+++ b/src/Entities/Properties/MultiSelect.php
@@ -2,6 +2,7 @@
 
 namespace FiveamCode\LaravelNotionApi\Entities\Properties;
 
+use FiveamCode\LaravelNotionApi\Entities\Contracts\Modifiable;
 use Illuminate\Support\Collection;
 use FiveamCode\LaravelNotionApi\Exceptions\HandlingException;
 use FiveamCode\LaravelNotionApi\Entities\PropertyItems\SelectItem;
@@ -10,7 +11,7 @@
  * Class MultiSelect
  * @package FiveamCode\LaravelNotionApi\Entities\Properties
  */
-class MultiSelect extends Property
+class MultiSelect extends Property implements Modifiable
 {
     /**
      * @param $names
diff --git a/src/Entities/Properties/Number.php b/src/Entities/Properties/Number.php
index baebd70..093c817 100644
--- a/src/Entities/Properties/Number.php
+++ b/src/Entities/Properties/Number.php
@@ -2,11 +2,13 @@
 
 namespace FiveamCode\LaravelNotionApi\Entities\Properties;
 
+use FiveamCode\LaravelNotionApi\Entities\Contracts\Modifiable;
+
 /**
  * Class Number
  * @package FiveamCode\LaravelNotionApi\Entities\Properties
  */
-class Number extends Property
+class Number extends Property implements Modifiable
 {
     /**
      * @var float|int
diff --git a/src/Entities/Properties/People.php b/src/Entities/Properties/People.php
index 2a0e839..b4722b3 100644
--- a/src/Entities/Properties/People.php
+++ b/src/Entities/Properties/People.php
@@ -2,6 +2,7 @@
 
 namespace FiveamCode\LaravelNotionApi\Entities\Properties;
 
+use FiveamCode\LaravelNotionApi\Entities\Contracts\Modifiable;
 use FiveamCode\LaravelNotionApi\Entities\User;
 use FiveamCode\LaravelNotionApi\Exceptions\HandlingException;
 use Illuminate\Support\Collection;
@@ -10,7 +11,7 @@
  * Class People
  * @package FiveamCode\LaravelNotionApi\Entities\Properties
  */
-class People extends Property
+class People extends Property implements Modifiable
 {
     /**
      * @param $userIds
diff --git a/src/Entities/Properties/PhoneNumber.php b/src/Entities/Properties/PhoneNumber.php
index a8ea4ce..e3a69b2 100644
--- a/src/Entities/Properties/PhoneNumber.php
+++ b/src/Entities/Properties/PhoneNumber.php
@@ -2,11 +2,13 @@
 
 namespace FiveamCode\LaravelNotionApi\Entities\Properties;
 
+use FiveamCode\LaravelNotionApi\Entities\Contracts\Modifiable;
+
 /**
  * Class PhoneNumber
  * @package FiveamCode\LaravelNotionApi\Entities\Properties
  */
-class PhoneNumber extends Property
+class PhoneNumber extends Property implements Modifiable
 {
     /**
      * @param $phoneNumber
diff --git a/src/Entities/Properties/Relation.php b/src/Entities/Properties/Relation.php
index 2a96e5b..b0a2bdf 100644
--- a/src/Entities/Properties/Relation.php
+++ b/src/Entities/Properties/Relation.php
@@ -2,13 +2,14 @@
 
 namespace FiveamCode\LaravelNotionApi\Entities\Properties;
 
+use FiveamCode\LaravelNotionApi\Entities\Contracts\Modifiable;
 use Illuminate\Support\Collection;
 
 /**
  * Class Relation
  * @package FiveamCode\LaravelNotionApi\Entities\Properties
  */
-class Relation extends Property
+class Relation extends Property implements Modifiable
 {
     /**
      * @param $relationIds
diff --git a/src/Entities/Properties/Select.php b/src/Entities/Properties/Select.php
index d898d5e..33a47bb 100644
--- a/src/Entities/Properties/Select.php
+++ b/src/Entities/Properties/Select.php
@@ -2,6 +2,7 @@
 
 namespace FiveamCode\LaravelNotionApi\Entities\Properties;
 
+use FiveamCode\LaravelNotionApi\Entities\Contracts\Modifiable;
 use FiveamCode\LaravelNotionApi\Exceptions\HandlingException;
 use FiveamCode\LaravelNotionApi\Entities\PropertyItems\SelectItem;
 
@@ -9,7 +10,7 @@
  * Class Select
  * @package FiveamCode\LaravelNotionApi\Entities\Properties
  */
-class Select extends Property
+class Select extends Property implements Modifiable
 {
 
     /**
diff --git a/src/Entities/Properties/Text.php b/src/Entities/Properties/Text.php
index 29394a0..310fd19 100644
--- a/src/Entities/Properties/Text.php
+++ b/src/Entities/Properties/Text.php
@@ -2,6 +2,7 @@
 
 namespace FiveamCode\LaravelNotionApi\Entities\Properties;
 
+use FiveamCode\LaravelNotionApi\Entities\Contracts\Modifiable;
 use FiveamCode\LaravelNotionApi\Exceptions\HandlingException;
 use FiveamCode\LaravelNotionApi\Entities\PropertyItems\RichText;
 
@@ -9,7 +10,7 @@
  * Class Text
  * @package FiveamCode\LaravelNotionApi\Entities\Properties
  */
-class Text extends Property
+class Text extends Property implements Modifiable
 {
     /**
      * @var string
diff --git a/src/Entities/Properties/Title.php b/src/Entities/Properties/Title.php
index acece50..c9c9195 100644
--- a/src/Entities/Properties/Title.php
+++ b/src/Entities/Properties/Title.php
@@ -2,6 +2,7 @@
 
 namespace FiveamCode\LaravelNotionApi\Entities\Properties;
 
+use FiveamCode\LaravelNotionApi\Entities\Contracts\Modifiable;
 use FiveamCode\LaravelNotionApi\Exceptions\HandlingException;
 use FiveamCode\LaravelNotionApi\Entities\PropertyItems\RichText;
 
@@ -9,7 +10,7 @@
  * Class Title
  * @package FiveamCode\LaravelNotionApi\Entities\Properties
  */
-class Title extends Property
+class Title extends Property implements Modifiable
 {
     /**
      * @var string
diff --git a/src/Entities/Properties/Url.php b/src/Entities/Properties/Url.php
index 622d226..843643a 100644
--- a/src/Entities/Properties/Url.php
+++ b/src/Entities/Properties/Url.php
@@ -2,11 +2,13 @@
 
 namespace FiveamCode\LaravelNotionApi\Entities\Properties;
 
+use FiveamCode\LaravelNotionApi\Entities\Contracts\Modifiable;
+
 /**
  * Class Url
  * @package FiveamCode\LaravelNotionApi\Entities\Properties
  */
-class Url extends Property
+class Url extends Property implements Modifiable
 {
     /**
      * @param $url

From 694c4876003bfdb6e9721fc68c2c3f3739ec56df Mon Sep 17 00:00:00 2001
From: JohGuentner <3506359+johguentner@users.noreply.github.com>
Date: Sat, 21 Aug 2021 20:24:12 +0200
Subject: [PATCH 2/2] removed $value from Modifiable-Interface - $value is
 different for each property - the empty Interface should be sufficient for
 checking, if the property is modifiable

---
 src/Entities/Contracts/Modifiable.php | 1 -
 1 file changed, 1 deletion(-)

diff --git a/src/Entities/Contracts/Modifiable.php b/src/Entities/Contracts/Modifiable.php
index 6e2095e..8db97c3 100644
--- a/src/Entities/Contracts/Modifiable.php
+++ b/src/Entities/Contracts/Modifiable.php
@@ -6,5 +6,4 @@
 
 interface Modifiable
 {
-    public static function value($value): Property;
 }
\ No newline at end of file