Contact Logs & Call States #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some contacts are actually just local offices (like Corps of Engineers), we still need to have valid contacts for these if some of the fields aren’t present.
(This normally happens for us by default if we’re using UITableViewController, but alas…)
Instead of having a key for each type of location & value, we use 3 keys: type, display, and value. Each will store a string.
This seemed to cause issues where an image refused to load
This allows us to separate mutable user state from the JSON responses, and allows us to ask questions like "Have I completed this issue?" or "Have I called this contact about this issue?" in order to drive the checkmarks on the UI.
… a state to the Call Script to avoid repeating log calls when returning to a completed contact.
|
🙏 for finding a useful thing to put in the title! |
|
Looks good, but needs another merge from master |
# Conflicts: # FiveCalls/FiveCalls.xcodeproj/project.pbxproj # FiveCalls/FiveCalls/CallScriptViewController.swift
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contact X of Yon the top of the Script screen to give better context.Completes issues: #24 & #12