Format patch #6

Closed
wants to merge 5 commits into
from

Conversation

Projects
None yet
2 participants
@baopham
Contributor

baopham commented Apr 12, 2012

This pull request #5 is not so helpful so I tried to finish some of the TODO's.

It will allow users to customize their tag link format and title separator

require 'karakuri'

Karakuri.link_format '<a href="/tagged?tag={tag}" title="whatever here">{tag}</a> ' 
Karakuri.title_separator '+'

{tag} will then be replaced in the function tag_link_list with the appropriate tag of each article

@5v3n

This comment has been minimized.

Show comment Hide comment
@5v3n

5v3n Apr 21, 2012

Owner

great to see another contribution, you rock :-)!

atomic commits are totally ok - in fact I'd prefer to see #5 as standalone pull request & the new features as another one.

motivation: if we overlooked a bug that's introduced by feature A, we don't want to remove feature B that was commited alongside. with small atomic commits we can just deactivate feature A & still enjoy feature B.

would be great if you'd separate it again - then the green "Merge pull request"-button is ready for action ;-)

Owner

5v3n commented Apr 21, 2012

great to see another contribution, you rock :-)!

atomic commits are totally ok - in fact I'd prefer to see #5 as standalone pull request & the new features as another one.

motivation: if we overlooked a bug that's introduced by feature A, we don't want to remove feature B that was commited alongside. with small atomic commits we can just deactivate feature A & still enjoy feature B.

would be great if you'd separate it again - then the green "Merge pull request"-button is ready for action ;-)

@baopham baopham referenced this pull request Apr 22, 2012

Closed

Format patch2 #7

@baopham

This comment has been minimized.

Show comment Hide comment
@baopham

baopham Apr 22, 2012

Contributor

Oh I see
If I understand correctly please take a look at #7 I just committed. Thanks!

Contributor

baopham commented Apr 22, 2012

Oh I see
If I understand correctly please take a look at #7 I just committed. Thanks!

@baopham baopham closed this Apr 22, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment