changed the project's setup to embrace conventions #18

Merged
merged 5 commits into from Jun 13, 2011

Conversation

Projects
None yet
2 participants
@rubiii
Contributor

rubiii commented Jun 13, 2011

hey sven,

tweetlr already was compatible with ruby 1.8. the only problem was related to the bin and specs using require_relative. nevertheless i changed the project's setup to embrace certain conventions established by the ruby/bundler community:

i also added the development dependencies specified in the Gemfile to the gemspec and added explicit versions which could probably be adjusted to work with older releases.

rubiii added some commits Jun 13, 2011

changed the project's setup to embrace conventions
- don't require rubygems (https://gist.github.com/54177)
- use a gemspec to dry up dependency specification
- specify development dependencies (json was missing)
- use bundler to require test dependencies
- replace the test task with an rspec test task
@5v3n

This comment has been minimized.

Show comment
Hide comment
@5v3n

5v3n Jun 13, 2011

Owner

I knew there would be only little adjustments necessary for 1.8 compatibility.

What I didn't knew was that the project was lacking some basic best practices. Thanks a lot for this comment mate, I learned a lot.

Is there a way to configure the gemspec for specific ruby versions? E.g. 1.9 does not need json & rdoc causes warnings with rake spec, whereas 1.8 does need json & w/o the rdoc gem rake spec does not run.

Cheers & thanks again!

Owner

5v3n commented Jun 13, 2011

I knew there would be only little adjustments necessary for 1.8 compatibility.

What I didn't knew was that the project was lacking some basic best practices. Thanks a lot for this comment mate, I learned a lot.

Is there a way to configure the gemspec for specific ruby versions? E.g. 1.9 does not need json & rdoc causes warnings with rake spec, whereas 1.8 does need json & w/o the rdoc gem rake spec does not run.

Cheers & thanks again!

@5v3n 5v3n merged commit 3d2887b into 5v3n:master Jun 13, 2011

@rubiii

This comment has been minimized.

Show comment
Hide comment
@rubiii

rubiii Jun 14, 2011

Contributor

great :) i'll have a look at the problems later today.

Contributor

rubiii commented Jun 14, 2011

great :) i'll have a look at the problems later today.

@rubiii

This comment has been minimized.

Show comment
Hide comment
@rubiii

rubiii Jun 14, 2011

Contributor

as far as i know, there's no "decent" way to release separate gems for different ruby versions. so i would keep the dependency on the json gem as it's needed for ruby 1.8. talking about rdoc, i think it's fine to add it as a development dependency. plus, adding rdoc and using a fairly recent version, i'm not getting any warnings.

Contributor

rubiii commented Jun 14, 2011

as far as i know, there's no "decent" way to release separate gems for different ruby versions. so i would keep the dependency on the json gem as it's needed for ruby 1.8. talking about rdoc, i think it's fine to add it as a development dependency. plus, adding rdoc and using a fairly recent version, i'm not getting any warnings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment