Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Artifacts on the sample image #3

Closed
p4vook opened this issue Jan 9, 2021 · 4 comments
Closed

Artifacts on the sample image #3

p4vook opened this issue Jan 9, 2021 · 4 comments

Comments

@p4vook
Copy link

p4vook commented Jan 9, 2021

The sample image has some artifacts: for example, the part of the "floor" which is the nearest to the camera appears convex.
@64
Copy link
Owner

64 commented Jan 10, 2021

Indeed - I haven't looked at the code in a while, but I'd suspect that it's due to how I generate the checkerboard pattern.

@fidergo-stephane-gourichon
Copy link
Contributor

The checkerboard pattern does have a bug, but a different one.

@fidergo-stephane-gourichon
Copy link
Contributor

Fixed that in #5.

The checkerboard pattern does have a bug, but a different one.

Fixed that other bug in #4.

@fidergo-stephane-gourichon
Copy link
Contributor

See this comment for result of merging #4, #5, #6 and #7.

You can thank https://news.ycombinator.com/item?id=25700038 .

@64 64 closed this as completed Jan 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@fidergo-stephane-gourichon @64 @p4vook