Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Retaining NSTimer objects #46

Closed
eofster opened this Issue Feb 11, 2012 · 2 comments

Comments

Projects
None yet
2 participants
Owner

eofster commented Feb 11, 2012

Check whether we retain NSTimer objects and whether we have to do that.

@eofster eofster was assigned Feb 11, 2012

Hello, there have been several releases of Telephone since this issue was created. Could you please download and run the latest version to confirm this issue still exists.

Sorry for the template response, just trying to clean up and close old issues here.

@eofster eofster modified the milestone: 1.1.5, 1.1 Sep 14, 2015

Owner

eofster commented Mar 23, 2016

Currently, Telephone’s objects hold strong references to the repeating timers. For the sake of memory management, it doesn’t matter if those references are strong or weak. What matters is which objects are used as timer targets and if the timers are invalidated at the appropriate times.

If it doesn’t matter if the property is strong or weak, the properties referring to objects should use the default, strong, type to avoid confusion and guessing on the caller’s part.

@eofster eofster closed this Mar 23, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment