Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: BREAKING CHANGE - replace jQueryUI with SortableJS #695

Merged
merged 5 commits into from Sep 22, 2022

Conversation

ghiscoding
Copy link
Collaborator

@ghiscoding ghiscoding commented Sep 19, 2022

This PR does

  • replace jQueryUI with SortableJS
  • replace jquery.event.drag-2.3.0.js and jquery.mousewheel.js with a new file slick.interactions.js
    • jquery.mousewheel.js is now totally useless, however jquery.event.drag will be used when imported or else default to slick.interactions
  • for more info, read SlickGrid 3.0 Wiki
  • the new minified versions will be provided in a future PR
    • Note that 1 Cypress E2E test is currently failing because Example 4 has reference to these minified files which are not yet included
    • the minified files will be created by running npm run minify script
  • this PR will be merged to the next branch first (not master)
  • fixes issue remove jQueryUI Sortable dependency #541 and Drag is not working in Mobile mode #488

- replace jQueryUI by SortableJS
- replace `jquery.event.drag-2.3.0.js` & `jquery.mousewheel.js` by `slick.interactions.js`
- add script to minify JS/CSS files
- add script to bump version in package.json, this will probably be replaced by external lib in the short term
@ghiscoding
Copy link
Collaborator Author

ghiscoding commented Sep 20, 2022

@6pac
This is the 1st PR, another PR will follow with minified files but I wanted to have a smaller PR for you to review. The "Example4 (most comprehensive)" will not work without these new minified files (next PR) but everything else will work. You can run npm run minify to get the minified files. Also note that this PR is to be merged to the next branch (not master), so you don't have to worry about merging too early, I'll work on adding version bump script in a future PR as well. So give it a try and let me know, please merge (to next) when you're ready (we're not going to merge to master until couple more weeks but let's merge this one in the next couple days if you can and don't worry about the failing test for now)

Oh and I also forgot to mention, I`ve done all changes and tests for all my 3 libs and I'm good to go. At this point it's basically the scripts that I promised for version automation and for you to give feedback and we should be good to release quite soon. Cheers

@ghiscoding ghiscoding merged commit 386cd58 into next Sep 22, 2022
@ghiscoding
Copy link
Collaborator Author

will merge now since a few more PRs are expected to come quite soon on this next branch

@ghiscoding ghiscoding changed the title feat: BREAKING CHANGE - replace jQueryUI with SortableJS feat!: BREAKING CHANGE - replace jQueryUI with SortableJS Sep 25, 2022
ghiscoding pushed a commit that referenced this pull request Oct 12, 2022
* feat: BREAKING CHANGE - replace jQueryUI with SortableJS (#695)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant