Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Add 508 accessibility enhancements suggested by mleibman#616 #87
Add 508 accessibility enhancements suggested by the GitHub commit documented here: mleibman#616.
This code adds role attributes that allow the JAWS screen reader (a common accessibility tool) to identify SlickGrid as a table and read the columns and data on the page. I’ve looked at the suggested changes, and although the current 6pac code base has marched forward from the original repo, the current 6pac codebase looks sufficiently (IMHO) similar to the original mleibman codebase to make a migration possible.
Additionally, a single-line change to slick.grid.js is required to ensure that Chrome’s accessibility tree is generated correctly in some newer versions of Chrome (49+).
This submission is being made on behalf of the USPTO, an agency of the United States Department of Commerce (DOC), to support the open source community. The United States Department of Commerce (DOC) GitHub project code is provided on an ‘as is’ basis and the user assumes responsibility for its use. DOC has relinquished control of the information and no longer has responsibility to protect the integrity, confidentiality, or availability of the information. Any claims against the Department of Commerce stemming from the use of its GitHub project will be governed by all applicable Federal law. Any reference to specific commercial products, processes, or services by service mark, trademark, manufacturer, or otherwise, does not constitute or imply their endorsement, recommendation or favoring by the Department of Commerce. The Department of Commerce seal and logo, or the seal and logo of a DOC bureau, shall not be used in any manner to imply endorsement of any commercial product or activity by DOC or the United States Government.
Thanks, for progressing this. It's a tricky one. Given that it looks like the adjustments may cause problems (there's the focus/scrolling issue, and even adding div's in might cause problems if people have written code for a particular SlickGrid container structure), either a plugin or an option-based implementation is safest until it's mature. No problem with the philosophy of it 'just being built in', but this is a long term goal rather than something we can do right now.