fix #371 for number larger than 2.14 billion#374
Conversation
|
Sorry, but I have to ask the obvious ... you have more than 2 billion rows? Also, if you're going to go into the floating point numeric scope, you're going to have problems with precision: https://stackoverflow.com/questions/33773296/is-there-or-isnt-there-an-integer-type-in-javascript edit: Ah, OK bitwise is 32 bit, we're aiming for the full SAFE_INT scope. Still checking my javascript apocrypha to see what the impact is... So I'm not sure exactly what empty value this is working against, but I think it would be more likely to be an |
|
Thanks for the feedback and I will update the code as recommended. Note, I took the path or using a To answer your other question... Yes, we have very large datasets with some reaching into the multiple billions. An internal user identified the bug when attempting to get the context menu on a row in the 5 billion range. |
|
FYI, The row is a string so we do need to parse the integer. Which is addressed on my latest commit. |
|
Awesome. Just trying to keep the code as bulletproof as possible! |
Fixes issue (#371) with large numbers by removing the bitwise operation used on row index. I did not change bitwise operations done against column indices.