This repository was archived by the owner on Feb 18, 2022. It is now read-only.
Fix mobile year selection issue #201 #222
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@tipycalFlow thanks! have you checked if years selection is ok on no-mobile too? |
Contributor
Author
|
Works the same on chrome for mac. Might need to check on other browsers. |
Member
|
@tipycalFlow great! yes try please at least safari, firefox and IE 10/11 if you have them. Then i'll merge this, let me know i am here don't worry :) |
Contributor
Author
|
Tested with safari iOS 10, safari for mac, firefox, IE 11&10 (user-agents from safari's |
Member
|
@tipycalFlow awesome, it's enough, the js is angular so will run everywhere hopefully. Going to merge and release this. |
Member
|
shipped in new 2.1.10 thanks @tipycalFlow 👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.