New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update activity.py #28

Merged
merged 1 commit into from Sep 13, 2016

Conversation

Projects
None yet
2 participants
@Allianzcortex
Contributor

Allianzcortex commented Sep 13, 2016

just use dict.values() 花了两天时间看了一遍,整体代码非常漂亮~~,对异常值的判断和 BaseException 的继承都是工业级别的水准,@decorators 也非常 nice,7s 是看过 requests 的源码嘛。。我能做的也就是一些语法的修改了:-D

Update activity.py
just use dict.values()
@7sDream

This comment has been minimized.

Show comment
Hide comment
@7sDream

7sDream Sep 13, 2016

Owner

其实还没看过 requests,本来是准备看的,但是最近因为跑去玩 Go 去了 Python 这边没怎么上心来着~

因为是有上一个 zhihu-py3 那个库的失败经验嘛……(如果你敢看那个 repo 的代码的话……就能发现什么叫烂到不行了,我自己都要放弃那边了)写这个的时候就知道哪里会有坑,怎么写比较好……

Owner

7sDream commented Sep 13, 2016

其实还没看过 requests,本来是准备看的,但是最近因为跑去玩 Go 去了 Python 这边没怎么上心来着~

因为是有上一个 zhihu-py3 那个库的失败经验嘛……(如果你敢看那个 repo 的代码的话……就能发现什么叫烂到不行了,我自己都要放弃那边了)写这个的时候就知道哪里会有坑,怎么写比较好……

@7sDream 7sDream merged commit b172920 into 7sDream:dev Sep 13, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment