New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compact format like travis #70
Comments
I misunderstood the intent of your comment. Wouldn't it be more compact if you wrote the following? steps:
- uses: 8398a7/action-slack@v3
with:
status: ${{ job.status }}
fields: ''
env:
SLACK_WEBHOOK_URL: ${{ secrets.SLACK_WEBHOOK_URL }} # required The job took is not on the agenda here, as we want to discuss it in issue #38. |
Hi,
but only status is not enough, is it? Or do you display all the other information too (action link, hash link, author, duration, message)?
Cheers, Fons.
… On 12 Jun 2020, at 16:28, 839 ***@***.***> wrote:
@FonsRademakers
I misunderstood the intent of your comment.
If you want a compact format, such as travis, you can leave the fields unspecified so that only the text you choose to display is shown.
Wouldn't it be more compact if you wrote the following?
steps
:
-
uses: ***@***.***
with
:
status: ${{ job.status }}
fields: ''
env
:
SLACK_WEBHOOK_URL: ${{ secrets.SLACK_WEBHOOK_URL }} # required
The job took is not on the agenda here, as we want to discuss it in issue #38.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.
--------------------------------------------------------------------------
Dr. Fons Rademakers CERN - European Organization for Nuclear Research
Chief Research Officer 1211 Geneve 23, Switzerland
CERN openlab Tel: +41227679248 Mobile: +41754113742
--------------------------------------------------------------------------
|
Do you think the problem is that the current format makes it too vertical? Do you assume you want to display the following format? Succeeded GitHub Actions |
Example: Where macOS CI is a link to the specific action and where 63edc15 is a link to the pushed code. Having more links or links pointing the same is just confusing. Thanks, Fons. |
Thank you. Do you use v2 for this? |
I use v3:
which gives this way to vertical format. Could you not just make one option for a compact format, like: with: or something like that. There are infinite number of patterns, but now there is not a single good one. ;-) |
If a library provides I think it's possible to display them as a comma-separated list instead of using slack attachments. The values are assumed to be as follows. - name: Notify Slack
uses: 8398a7/action-slack@v3
with:
status: ${{ job.status }}
author_name: Integration Test
fields: repo,ref,message,author,action,workflow # default: repo,commit
style: compact
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} # optional
SLACK_WEBHOOK_URL: ${{ secrets.SLACK_WEBHOOK_URL }} # required
if: always() # Pick up events even if the job fails or is canceled. By the way, if you restrict the fields like |
I like 'style: compact', but as compact message I would propose: "Workflow" macOS CI where "workflow", "action", "hash" are links. The log message has an entire line, as message are typically more than 20 chars. This message is very clear and does not need any redundant keywords to be understandable, like 'repo', 'commit', 'author', 'eventName', 'ref', 'workflow' and 'job'. Everything is clear and concise. I an my users would be grateful as we get many action Slack message per day. Cheers, Fons. |
The template itself is great. steps:
- uses: 8398a7/action-slack@v3
with:
status: custom
custom_payload: |
{
text: "${this.workflow()}\n${this.job()} (${this.commit()}) of ${this.repo()}@${this.branch()} by ${this.author()} ${job.status()} in ${took()}\n${message()}",
}
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} # optional
SLACK_WEBHOOK_URL: ${{ secrets.SLACK_WEBHOOK_URL }} # required This is a big change and it may take some time. |
I'm perfectly fine with this. Is this available right now in v3?
|
No, it's not available. There are no destructive changes, though, so I think the release will be v3. |
Fantastic. Looking forward to testing it. |
It doesn't support branch information that action-slack doesn't have, but we've provided it as a basic feature. If you need branch information, I'm always open to contributions! Thanks for the suggestions and discussion. |
Hi,
thanks for the new feature!
In the example on:
https://action-slack.netlify.app/usecase/02-custom
you’ve two typos:
type: custom -> status: custom
below:
status: cutom -> status: custom
Cheers, Fons.
… On 28 Jun 2020, at 15:37, 839 ***@***.***> wrote:
It doesn't support branch information that action-slack doesn't have, but we've provided it as a basic feature.
refs: https://action-slack.netlify.app/usecase/02-custom
If you need branch information, I'm always open to contributions!
Thanks for the suggestions and discussion.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.
--------------------------------------------------------------------------
Dr. Fons Rademakers CERN - European Organization for Nuclear Research
Chief Research Officer 1211 Geneve 23, Switzerland
CERN openlab Tel: +41227679248 Mobile: +41754113742
--------------------------------------------------------------------------
|
Hi,
I noticed that for both Ubuntu builds not all fields are correctly filled in (link to build undefined and build time missing). See the screenshot below. For CentOS CI (docker build) and macOS CI all looks fine. In all cases I use the same Slack workflow statement. HOWEVER, for the Ubuntu workflow I have:
build:
strategy:
matrix:
os: [ubuntu-18.04, ubuntu-20.04]
runs-on: ${{ matrix.os }}
could it be that the state for the two Ubuntu runs gets mixed up or overwritten?
Cheers, Fons
… On 29 Jun 2020, at 09:29, Fons Rademakers ***@***.***> wrote:
Hi,
thanks for the new feature!
In the example on:
https://action-slack.netlify.app/usecase/02-custom
you’ve two typos:
type: custom -> status: custom
below:
status: cutom -> status: custom
Cheers, Fons.
> On 28 Jun 2020, at 15:37, 839 ***@***.***> wrote:
>
>
> It doesn't support branch information that action-slack doesn't have, but we've provided it as a basic feature.
> refs: https://action-slack.netlify.app/usecase/02-custom
>
> If you need branch information, I'm always open to contributions!
> Thanks for the suggestions and discussion.
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub, or unsubscribe.
>
--------------------------------------------------------------------------
Dr. Fons Rademakers CERN - European Organization for Nuclear Research
Chief Research Officer 1211 Geneve 23, Switzerland
CERN openlab Tel: +41227679248 Mobile: +41754113742
--------------------------------------------------------------------------
--------------------------------------------------------------------------
Dr. Fons Rademakers CERN - European Organization for Nuclear Research
Chief Research Officer 1211 Geneve 23, Switzerland
CERN openlab Tel: +41227679248 Mobile: +41754113742
--------------------------------------------------------------------------
|
I haven't investigated the behavior when using matrix, so there may be a possibility of mixing it up. |
I’ve submitted a new issue with the screenshot attached.
Cheers, Fons.
… On 29 Jun 2020, at 16:09, 839 ***@***.***> wrote:
I haven't investigated the behavior when using matrix, so there may be a possibility of mixing it up.
Also, no screenshots seem to be attached... 😢
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.
--------------------------------------------------------------------------
Dr. Fons Rademakers CERN - European Organization for Nuclear Research
Chief Research Officer 1211 Geneve 23, Switzerland
CERN openlab Tel: +41227679248 Mobile: +41754113742
--------------------------------------------------------------------------
|
The text was updated successfully, but these errors were encountered: