Fixed Olivetti M19 display bug #1886
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Summary
While I was debugging the M240 option ROM issue #1861 (which was resolved by OBattler before I committed my modifications), I found out that Olivetti M19 was set to 40x25 CGA text mode instead of 80x25 M24/AT&T text mode. Turned out to be an issue in the way jumper settings are read by the keyboard controller, so I corrected it.
As this bug was identified and corrected by myself, I haven't created an issue. If needed for tracking purposes, I can create one though.
Checklist