New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix null termination issue in opengl shader version replacement #1915

Merged

OBattler merged 1 commit into 86Box:master from ts-korhonen:master

Dec 5, 2021

Contributor

ts-korhonen commented Dec 5, 2021

Summary

The fix in #1913 didn't work in 32bit release builds, most likely due to missing null terminating character. Changed the way the string is copied for less error prone method.

Checklist

Closes #xxx
I have discussed this with core contributors already
This pull request requires changes to the ROM set
- I have opened a roms pull request - https://github.com/86Box/roms/pull/changeme/

References

Provide links to datasheets or other documentation that helped you implement this pull request.


          Fix null termination issue in previous shader version fix

983872f

OBattler merged commit 652cbb5 into 86Box:master

29 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment