Error handling updates on OpenGL 3.0 renderer #1920
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Show message box on fail. Enable debug output only when logfile is defined; performance optimization. Fail if reported opengl version is less than 3.0 or errors are generated after context is created; fixes some crashes on unsupported hardware or faulty drivers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Summary
General failure notice message box to OpenGL 3.0 renderer initialization failure.
Fail if reported OpenGL version is less than 3.0 or errors are generated after context is created. This should fix some crashes on unsupported hardware or faulty drivers.
Enable debug output only when logfile is defined as debug mode can include a performance hit.
Checklist
References
Provide links to datasheets or other documentation that helped you implement this pull request.