Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix window resizing not always working #1940

Merged
merged 3 commits into from Dec 17, 2021
Merged

Fix window resizing not always working #1940

merged 3 commits into from Dec 17, 2021

Conversation

Copy link
Contributor

@ts-korhonen ts-korhonen commented Dec 17, 2021

Summary

Window resizing doesn't always register. It's most noticeable on changing scaling factor. This is because int doresize is used from multiple threads to communicate the need to resize the window. This sometimes leads to lost changes of it's value when it happens concurrently.

The fix here is to replace it with atomic_flag which is performant way to deal with this kind of concurrency problem without introducing locks or mutexes.

Checklist

References

Provide links to datasheets or other documentation that helped you implement this pull request.

@OBattler OBattler merged commit ae128eb into 86Box:master Dec 17, 2021
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants