Fix window resizing not always working #1940
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Summary
Window resizing doesn't always register. It's most noticeable on changing scaling factor. This is because
int doresizeis used from multiple threads to communicate the need to resize the window. This sometimes leads to lost changes of it's value when it happens concurrently.The fix here is to replace it with atomic_flag which is performant way to deal with this kind of concurrency problem without introducing locks or mutexes.
Checklist
References
Provide links to datasheets or other documentation that helped you implement this pull request.