New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes for midi input #1979

Merged

dhrdlicka merged 1 commit into 86Box:master from ts-korhonen:midi-fix

Jan 7, 2022

Contributor

ts-korhonen commented Jan 7, 2022

Summary

Fix buffer overflow on midi input messages by passing length of the message.
Detect sysex messages by the first byte instead of length.

Checklist

Closes #xxx
I have discussed this with core contributors already
This pull request requires changes to the ROM set
- I have opened a roms pull request - https://github.com/86Box/roms/pull/changeme/

References

Provide links to datasheets or other documentation that helped you implement this pull request.


          Fixes for midi input

2ad80a2

- Fix buffer overflow in midi input messages
- Detect sysex messages by starting byte instead of length

dhrdlicka merged commit e9332cf into 86Box:master

29 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment