New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix UART-mode detection on input sysex messages #1983

Merged

OBattler merged 1 commit into 86Box:master from ts-korhonen:midi-fix

Jan 7, 2022

Contributor

ts-korhonen commented Jan 7, 2022

Summary

mpu->intelligent is still true even when mpu-401 has reveived command to switch to UART-mode. Fix the check to only compare mpu->mode.

Checklist

Closes #xxx
I have discussed this with core contributors already
This pull request requires changes to the ROM set
- I have opened a roms pull request - https://github.com/86Box/roms/pull/changeme/

References

Provide links to datasheets or other documentation that helped you implement this pull request.


          Properly UART-mode detection on input sysex messages

edc8c88

ts-korhonen force-pushed the midi-fix branch from 29f74c5 to edc8c88 Compare

OBattler merged commit 750f00d into 86Box:master

29 checks passed

ts-korhonen deleted the midi-fix branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment