Exit full screen mode if changing window (with alt-tab) #1988
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
with alt-tab etc. unintended way.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
If the user leaves full screen window by alt-tab or similar method (unintended way), 86Box goes into an unstable state; mouse cursor can be hidden or clipped to an arbitrary area and the rendering can be distorted.
Fixing this "properly" would mean refactoring the way windows and renderers are created and going through the process in which window and video resizing works to ensure proper operation.
In this PR is a simpler solution that makes 86Box leave full screen if the user leaves the program.
Summary
Briefly describe what you are submitting.
Checklist
References
Provide links to datasheets or other documentation that helped you implement this pull request.