Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor update ru-RU.rc #2008

Merged
merged 2 commits into from Jan 24, 2022
Merged

Minor update ru-RU.rc #2008

merged 2 commits into from Jan 24, 2022

Conversation

Copy link
Contributor

@KeishiX KeishiX commented Jan 24, 2022

Summary

Fixed a couple strings.

Checklist

References

Provide links to datasheets or other documentation that helped you implement this pull request.

@@ -295,7 +295,7 @@ END
#define STR_MACHINE "Системная плата:"
#define STR_CONFIGURE "Настройка"
#define STR_CPU_TYPE "Тип ЦП:"
#define STR_SPEED "Частота:"
#define STR_SPEED "Speed:"
Copy link
Contributor

@lemondrops lemondrops Jan 24, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The space for the CPU speed string will be expanded in the future (@jriwanek is working on it), so there is no need to change the string back.

Copy link
Contributor Author

@KeishiX KeishiX Jan 24, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's ok, but there's another issue. This string is also used for CD-ROM speed option for which it is incorrect.

Copy link
Contributor

@lemondrops lemondrops Jan 24, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then, I guess it should be translated as "Скорость:" for now. While it will be clipped on the machine page, it is going to be fixed soon, anyway. The part about the string being used in two different context is noted and passed over to the rest of the development team.

Copy link
Contributor Author

@KeishiX KeishiX Jan 24, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, great. I changed it as you suggested. I hope there's no other objections about PR.

@OBattler OBattler merged commit 15b990f into 86Box:master Jan 24, 2022
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants